add clearer error status codes

routes/api/dms/post.js

@@ -22,18 +22,22 @@ export const setup = function (router, con, server) {
     });
     router.post("/api/dms/post",  function (req, res) {
         if (!req.body.message) {
+            res.status(410)
             res.json({ "error": "no message to post" });
             return;
         }
         if ((typeof req.body.message) != "string") {
+            res.status(411)
             res.json({ "error": "no message to post" });
             return;
         }
         if ((typeof req.body.pid) != "string") {
+            res.status(412)
             res.json({ "error": "no pid given" });
             return;
         }
         if (req.body.pid.length != 10 || PIDS[req.body.pid] !== true) {
+            res.status(413)
             res.json({ "error": "invalid pid given" });
             return;
         }
@@ -46,33 +50,41 @@ export const setup = function (router, con, server) {
             reply_id = req.body.reply_id;
         }
         if ((typeof reply_id) != "number") {
+            res.status(414)
             res.json({ "error": "no valid reply id given" });
             return;
         }
         if (req.body.message.length > 1000) {
+            res.status(415)
             res.json({ "error": "message too long" });
             return;
         }
         req.body.message = encodeURIComponent(req.body.message.trim());
         if (req.body.message.length > 3000) {
+            res.status(416)
             res.json({ "error": "message too long" }); //check again after URI encoding it
             return;
         }
         req.body.receiver = encodeURIComponent(req.body.receiver || "");
         if (req.body.receiver == "" || req.body.receiver == encodeURIComponent(res.locals.username) || req.body.receiver.length > 100) {
-            res.status(400).json({ "error": "invalid receiver given" });
+            res.status(417).json({ "error": "invalid receiver given" });
             return;
         }
         let otherperson = req.body.receiver;
         if (!req.body.message) {
+            res.status(418)
             res.json({ "error": "no message to post" });
             return;
         }
         let sql = `insert into ipost.dms (dms_user_name,dms_text,dms_time,dms_receiver,dms_from_bot,dms_reply_id) values (?,?,?,?,?,?);`;
         let values = [encodeURIComponent(res.locals.username), req.body.message, Date.now(), otherperson, res.locals.isbot, reply_id];
         con.query(sql, values, function (err, result) {
-            if (err)
-                throw err;
+            if (err) {
+                res.status(500)
+                res.json({"error":"there's been an internal error"})
+                console.error(err)
+                return;
+            }
             // let post_obj = {
             //     post_user_name: encodeURIComponent(res.locals.username),
             //     post_text: req.body.message,