From a49946fca58072bb849bd7f5dd57527802b7218b Mon Sep 17 00:00:00 2001
From: Mystikfluu <Mystikfluu@gmail.com>
Date: Tue, 26 Jul 2022 01:17:04 +0200
Subject: [PATCH] made type checking easier to read

---
 routes/api/settingshandler.js | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/routes/api/settingshandler.js b/routes/api/settingshandler.js
index 7cbcbda..734ef9d 100644
--- a/routes/api/settingshandler.js
+++ b/routes/api/settingshandler.js
@@ -18,7 +18,17 @@ module.exports = {
                 res.json({"error":"no setting to change"})
                 return
             }
-            if(!((typeof req.body.value) in allowed_settings[req.body.setting])) {
+            
+            let types = allowed_settings[req.body.setting]
+            let allowed = false
+            let got = typeof req.body.value
+            for (let index = 0; index < types.length; index++) {
+                if(types[index] == got) {
+                    allowed = true;
+                    break;
+                }
+            }
+            if(!allowed) {
                 console.log(5,"incorrect type given, received, expected", typeof req.body.value, allowed_settings[req.body.setting])
                 res.json({"error":"no new setting value given"})
                 return