From f38404a6484bb89bcee27c7c8d3da06814285ee5 Mon Sep 17 00:00:00 2001 From: Wilhelm Schuster Date: Sun, 21 Dec 2025 16:56:10 +0100 Subject: [PATCH] Small refactoring for the prerelease tagging logic (#55) --- .github/workflows/label-reviews.yml | 2 +- .github/workflows/release-tags.yml | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/label-reviews.yml b/.github/workflows/label-reviews.yml index 2587a69..b57e165 100644 --- a/.github/workflows/label-reviews.yml +++ b/.github/workflows/label-reviews.yml @@ -18,7 +18,7 @@ jobs: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: github_token: ${{ secrets.GITHUB_TOKEN }} - # define which PR labels require how many aprroving reviewers + # define which PR labels require how many approving reviewers # Case sensitive and needs the full label name. rules_yaml: |- Affects Balance: 3 diff --git a/.github/workflows/release-tags.yml b/.github/workflows/release-tags.yml index bb5520d..5c6e3cd 100644 --- a/.github/workflows/release-tags.yml +++ b/.github/workflows/release-tags.yml @@ -85,9 +85,11 @@ jobs: - name: Release under current tag run: | - PRERELEASE="" + PRERELEASE_FLAG="" + # DreamAssemblerXXL unfortunately breaks if prereleases are tagged as such on GitHub, so we only check for + # $SNAPSHOT here. if [[ "$SNAPSHOT" == "true" ]]; then - PRERELEASE="--prerelease" + PRERELEASE_FLAG="--prerelease" fi CHANGELOG_OVERRIDE=".changelogs/${RELEASE_VERSION}.md" if [[ -f "$CHANGELOG_OVERRIDE" ]]; then @@ -104,7 +106,7 @@ jobs: --jq ".body" > "${CHANGELOG_FILE}" fi cat "${CHANGELOG_FILE}" - gh release create "${RELEASE_VERSION}" -F "${CHANGELOG_FILE}" $PRERELEASE ./build/libs/*.jar + gh release create "${RELEASE_VERSION}" -F "${CHANGELOG_FILE}" ${PRERELEASE_FLAG} ./build/libs/*.jar shell: bash continue-on-error: true env: