From 9a64d69ca059ba50ea393fc407e395303fa89a3c Mon Sep 17 00:00:00 2001 From: Wilhelm Schuster Date: Thu, 18 Sep 2025 10:56:34 +0200 Subject: [PATCH 1/2] Only try making a spotless fix PR when on the main repo (#52) --- .github/workflows/build-and-test.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 07d4c22..a38fc17 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -88,7 +88,11 @@ jobs: retention-days: 31 - name: Attempt to make a PR fixing spotless errors - if: ${{ failure() && steps.build_mod.conclusion == 'failure' && github.event_name == 'pull_request' && !github.event.pull_request.draft }} + if: >- + ${{ failure() && steps.build_mod.conclusion == 'failure' + && github.event_name == 'pull_request' + && !github.event.pull_request.draft + && github.event.pull_request.head.repo.full_name == github.repository }} run: | git reset --hard git checkout "${PR_BRANCH}" From 7efb286761695540301ec51869565f879d4ba66d Mon Sep 17 00:00:00 2001 From: Wilhelm Schuster Date: Thu, 18 Sep 2025 10:57:24 +0200 Subject: [PATCH 2/2] Add a sanity check to build-and-test workflow to prevent overzealous asset file optimizations (#51) --- .github/workflows/build-and-test.yml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index a38fc17..7771ece 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -135,3 +135,21 @@ jobs: - name: Test no prerelease dependencies used run: | ! grep -P -- "-pre(?!shadow)" dependencies.gradle* + + # See https://github.com/GTNewHorizons/GT5-Unofficial/pull/4880 + - name: Make sure asset files are not overoptimized + run: | + echo "Checking for grayscale asset files which are not supported by the java8 image loader" + fail=0 + set -o pipefail + while IFS= read -r -d $'\n' file; do + if $(file --brief -- "$file" | grep -q grayscale); then + printf "found grayscale image '%s'\n" "$file" + fail=1 + fi + done < <(gh pr diff --name-only "${PR_NUMBER}" | grep 'src/main/resources/.*\.png$') + + exit $fail + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + PR_NUMBER: ${{ github.event.number }}